Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix prod: Make dcp42 the default catalog (#6586) #6593

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Hotfix prod: Make dcp42 the default catalog (#6586) #6593

merged 1 commit into from
Sep 24, 2024

Conversation

dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented Sep 24, 2024 •
edited
Loading

Connected issue: #6586

Notes:

  • Deindex prod catalogs dcp41 and dcp41-it

Checklist

Author

  • Target branch is prod
  • Name of PR branch matches hotfixes/<GitHub handle of author>/<issue#>-<slug>-prod
  • On ZenHub, PR is connected to the issue it hotfixes
  • PR description links to connected issue
  • PR title is Hotfix prod: followed by title of connected issue
  • PR title references the connected issue

Author (hotfixes)

  • Added h tag to commit title or this PR does not include a temporary hotfix
  • Added H tag to commit title or this PR does not include a permanent hotfix
  • Added hotfix label to PR
  • This PR is labeled partial or represents a permanent hotfix

Author (before every review)

  • Rebased PR branch on prod, squashed old fixups
  • Ran make requirements_update or this PR does not modify requirements*.txt, common.mk, Makefile and Dockerfile
  • Added R tag to commit title or this PR does not modify requirements*.txt
  • This PR is labeled reqs or does not modify requirements*.txt

System administrator (after approval)

  • Actually approved the PR
  • Labeled PR as no sandbox
  • A comment to this PR details the completed security design review
  • PR title is appropriate as title of merge commit
  • Moved connected issue to Approved column
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Squashed PR branch and rebased onto prod
  • Sanity-checked history
  • Pushed PR branch to GitHub
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Moved connected issue to Merged stable column in ZenHub
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Pushed merge commit to GitLab prod
  • Build passes on GitLab prod
  • Reviewed build logs for anomalies on GitLab prod
  • Deleted PR branch from GitHub

Operator (reindex)

  • Deindexed all unreferenced catalogs in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Deindexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Indexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Started reindex in prod or neither this PR nor a failed, prior promotion requires it
  • Checked for, triaged and possibly requeued messages in both fail queues in prod or neither this PR nor a failed, prior promotion requires it
  • Emptied fail queues in prod or neither this PR nor a failed, prior promotion requires it
  • Created backport PR and linked to it in a comment on this PR

Operator

  • PR is assigned to no one

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@dsotirho-ucsc dsotirho-ucsc added hotfix [process] An PR with an urgent fix for prod reindex:prod [process] PR requires reindexing prod reindex:partial [process] PR allows for (de)indexing a specific source or catalog labels Sep 24, 2024
@github-actions github-actions bot added the orange [process] Done by the Azul team label Sep 24, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (cb83019) to head (1331760).
Report is 2 commits behind head on prod.

Additional details and impacted files 
@@           Coverage Diff           @@
##             prod    #6593   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         155      155           
  Lines       20739    20739           
=======================================
  Hits        17707    17707           
  Misses       3032     3032
Flag Coverage Δ
85.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 85.397%. remained the same
when pulling 1331760 on hotfixes/dsotirho-ucsc/6586-default-catalog-dcp42
into cb83019 on prod.

@hannes-ucsc hannes-ucsc added the no sandbox [process] PR will not be tested in the sandbox label Sep 24, 2024
@hannes-ucsc
Copy link
Member

Security design review

  • Security design review completed; this PR does not …
    • … affect authentication; for example:
      • OAuth 2.0 with the application (API or Swagger UI)
      • Authentication of developers with Google Cloud APIs
      • Authentication of developers with AWS APIs
      • Authentication with a GitLab instance in the system
      • Password and 2FA authentication with GitHub
      • API access token authentication with GitHub
      • Authentication with Terra
    • … affect the permissions of internal users like access to
      • Cloud resources on AWS and GCP
      • GitLab repositories, projects and groups, administration
      • an EC2 instance via SSH
      • GitHub issues, pull requests, commits, commit statuses, wikis, repositories, organizations
    • … affect the permissions of external users like access to
      • TDR snapshots
    • … affect permissions of service or bot accounts
      • Cloud resources on AWS and GCP
    • … affect audit logging in the system, like
      • adding, removing or changing a log message that represents an auditable event
      • changing the routing of log messages through the system
    • … affect monitoring of the system
    • … introduce a new software dependency like
      • Python packages on PYPI
      • Command-line utilities
      • Docker images
      • Terraform providers
    • … add an interface that exposes sensitive or confidential data at the security boundary
    • … affect the encryption of data at rest
    • … require persistence of sensitive or confidential data that might require encryption at rest
    • … require unencrypted transmission of data within the security boundary
    • … affect the network security layer; for example by
      • modifying, adding or removing firewall rules
      • modifying, adding or removing security groups
      • changing or adding a port a service, proxy or load balancer listens on
  • Documentation on any unchecked boxes is provided in comments below

@dsotirho-ucsc dsotirho-ucsc merged commit f535d2e into prod Sep 24, 2024
9 checks passed
@dsotirho-ucsc dsotirho-ucsc deleted the hotfixes/dsotirho-ucsc/6586-default-catalog-dcp42 branch September 24, 2024 23:35
@dsotirho-ucsc
Copy link
Contributor Author

Backport PR #6595

@dsotirho-ucsc dsotirho-ucsc removed their assignment Sep 24, 2024
hannes-ucsc added a commit that referenced this pull request Sep 25, 2024
@hannes-ucsc
[H] Backports: f535d2e (#6586, PR #6593) (PR #6595)
33796d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannes-ucsc hannes-ucsc hannes-ucsc approved these changes

Assignees
No one assigned
Labels
hotfix [process] An PR with an urgent fix for prod no sandbox [process] PR will not be tested in the sandbox orange [process] Done by the Azul team reindex:partial [process] PR allows for (de)indexing a specific source or catalog reindex:prod [process] PR requires reindexing prod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsotirho-ucsc @coveralls @hannes-ucsc